Skip to content

Fix flapping buienradar tests#36394

Merged
bdraco merged 1 commit into
home-assistant:devfrom
bdraco:buienradar_tests_flapping
Jun 2, 2020
Merged

Fix flapping buienradar tests#36394
bdraco merged 1 commit into
home-assistant:devfrom
bdraco:buienradar_tests_flapping

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jun 2, 2020

Proposed change

Fix flapping buienradar tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @mjj4791, @ties, mind taking a look at this pull request as its been labeled with a integration (buienradar) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco mentioned this pull request Jun 2, 2020
20 tasks
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playing Flappy Bird?

✅ 👍

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jun 2, 2020

Playing Flappy Bird?

✅ 👍

Seems like it

@bdraco bdraco merged commit eedbb86 into home-assistant:dev Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants